[tabular] Fix refit_full crash #4870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-4870-0bb52bb is done. |
prateekdesai04
approved these changes
Feb 11, 2025
0bb52bb to
71bdbf7
Compare
|
Job PR-4870-71bdbf7 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #4869
Description of changes:
For the 1.2 release, I refactored the sanity checks in BaggedEnsembleModel, and as part of it, I made it raise an exception if called with
k_fold=0, as previously we passed bothk_fold=0andk_fold=1to mean the same thing (doing refit_full). However, this actually made refit_full fail to work for models anymore. This wasn't caught in our unit tests because the fallback mechanism which uses the first fold model in case of an error made the unit tests continue to pass.I've fixed the issue by passing
k_fold=1instead ofk_fold=0during refit_full.I've also added a docstring to clarify this behavior in BaggedEnsembleModel, and a unit test to verify that it is working correctly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.