[core] make AbstractTrainer generic in model type, remove SimpleAbstractTrainer #4820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b084e3 to
7d62ff2
Compare
shchur
reviewed
Jan 22, 2025
timeseries/src/autogluon/timeseries/trainer/abstract_trainer.py
Outdated
Show resolved
Hide resolved
timeseries/src/autogluon/timeseries/trainer/abstract_trainer.py
Outdated
Show resolved
Hide resolved
timeseries/src/autogluon/timeseries/trainer/abstract_trainer.py
Outdated
Show resolved
Hide resolved
shchur
reviewed
Jan 22, 2025
c41a7c8 to
e449b2c
Compare
|
Job PR-4820-80d7394 is done. |
shchur
reviewed
Jan 23, 2025
Innixma
reviewed
Jan 23, 2025
|
Job PR-4820-7d251ff is done. |
shchur
approved these changes
Jan 28, 2025
Innixma
approved these changes
Jan 28, 2025
… SimpleAbstractTrainer
e598ea4 to
93455da
Compare
|
Job PR-4820-93455da is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… SimpleAbstractTrainer
Issue #, if available:
Description of changes:
AbstractTrainergeneric in the model type, allowing tighter type checking for timeseries. This signals to users thatAbstractTrainers will always be coupled to anAbstractModelobject that they work with. This is also a good first step for moving shared stuff out ofAbstractModeland refactoringAbstractTimeSeriesModelwhich still improperly inherits fromAbstractModel.SimpleAbstractTrainerfrom timeseries.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.