Skip to content

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Jan 15, 2025

Issue #, if available:

Description of changes:

  • Add test_version.py to ensure that we don't accidentally do a release with a version that doesn't include an explicit micro / minor version. For example, we released 1.2 instead of 1.2.0. While 1.2 is technically valid, it causes issues with some AWS logic such as docker builds that expect an explicit micro version.
  • Update the way we create our version.py file so the content aligns with the ruff formater. Previously it complained that the version file lacked a newline and should use " instead of ' for string values. This would lead to unnecessary clutter and confusing when users would perform automated linting prior to submitting a PR.

Example of the previous confusing lint message:

ruff format --diff "timeseries/"
--- timeseries/src/autogluon/timeseries/version.py
+++ timeseries/src/autogluon/timeseries/version.py
@@ -1,2 +1,3 @@
 """This is the autogluon version file."""
-__version__ = '1.2'
+
+__version__ = "1.2"

1 file would be reformatted, 65 files already formatted

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 1.3 Release milestone Jan 15, 2025
@Innixma Innixma requested a review from shchur January 15, 2025 00:58
Copy link

Job PR-4799-3dd7488 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4799/3dd7488/index.html

Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Innixma Innixma merged commit b96062b into autogluon:master Jan 15, 2025
27 checks passed
@Innixma Innixma deleted the test_version branch April 16, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants