use slash command arg for pr-sha #4744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c51be65 to
7159c41
Compare
tonyhoo
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR fixes a security concern that /platform_tests might pick up a malicious commit sent within the very brief timing gap between when a maintainer sends out
/platform_testscomment, and when the action dequeues and picks up the new malicious commit sha because it currently checks out the PR sha automatically. With this PR, it requires the maintainer to supply the commit sha in the slash command, and avoids the potential risk of running a malicious commit.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.