[tabular] Stratify regression tasks via binning #4586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-4586-8070c34 is done. |
8070c34 to
28e823d
Compare
|
Benchmark results were inconclusive. I'll wait to benchmark this more thoroughly in future. For now I've not enabled the regression stratification by default, but the user can still enable it. |
suzhoum
approved these changes
Jan 11, 2025
| """ | ||
| Parameters | ||
| ---------- | ||
| stratify : bool, default False |
There was a problem hiding this comment.
Shall we add the first few args in the docstring as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #4453
Resolves #4771
Description of changes:
Stratify regression and quantile tasks via binning when doing cross-validation (such as during bagging)
Fix bug in dynamic stacking cross-validation mode where stratification was not being done on binary/multiclass, but was being done on other problem_types (opposite of intention).
Added type hints
TODO: Benchmark
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.