Skip to content

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Jun 13, 2024

Issue #, if available:

Description of changes:

  • Enable ray logging by default when using DyStack
  • Improve logging quality
  • Rename force_ray_logging -> enable_ray_logging
  • Add ray private API call hack to stop ray from logging in the main process after logging in DyStack.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 1.1.1 Release milestone Jun 13, 2024
@Innixma Innixma requested review from rey-allan and suzhoum June 13, 2024 02:37
@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

Copy link

Job PR-4262-4de48f7 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4262/4de48f7/index.html

else:
logger.info(
f"\tRunning DyStack sub-fit in a ray process to avoid memory leakage. "
"Logs will not be shown until this process is complete, due to a limitation in ray. "
"You can force logging by specifying `ds_args={'force_ray_logging': True}`."
"Logs will not be shown until this process is complete (enable_ray_logging=False). "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by the statement, will logs show with enable_ray_logging=False

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ray process logs will not show if enable_ray_logging=False. This log will show because it isn't tied to ray.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add something like "Logs will not be shown until this process is complete. To enable logging in ray, use enable_ray_logging=True."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what the next line in the logging message is:

"You can experimentally enable logging by specifying `ds_args={'enable_ray_logging': True}`."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool!

Copy link
Contributor

@suzhoum suzhoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
botocore==1.34.125 botocore==1.34.126
llvmlite==0.42.0 llvmlite==0.43.0
boto3==1.34.125 boto3==1.34.126
numba==0.59.1 numba==0.60.0
botocore==1.34.125 botocore==1.34.126
llvmlite==0.42.0 llvmlite==0.43.0
boto3==1.34.125 boto3==1.34.126
numba==0.59.1 numba==0.60.0

@Innixma Innixma merged commit d1280cb into autogluon:master Jun 13, 2024
Copy link

Job PR-4262-6d2b5e4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4262/6d2b5e4/index.html

@Innixma Innixma deleted the tabular_ray_logging branch April 16, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants