Skip to content

Conversation

suzhoum
Copy link
Contributor

@suzhoum suzhoum commented Jun 11, 2024

Issue #, if available:

Description of changes:
The original pytorch2.1 sagemaker base images installs torchaudio 2.1.x, however, AutoGluon master installs torch 2.2.x will introduce incompatibility issues. Updating the sagemaker base image version would resolve this issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@suzhoum suzhoum marked this pull request as ready for review June 11, 2024 15:58
Copy link

Job PR-4256-598832d is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4256/598832d/index.html

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
pydantic==2.7.3 pydantic==2.7.4
pydantic==2.7.3 pydantic==2.7.4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does torchaudio get installed along with torch?
or is it separate?

Copy link
Contributor Author

@suzhoum suzhoum Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torchaudio is included in the sagemaker base image, previously we had the sagemaker torch 2.1 base image, so everything related to torch installs 2.1, but since our master is already installing torch 2.2 by default, and we don't install torchaudio, torchaudio stays at 2.1.x. Somehow it's causing issues when I ran the tests in AutoGluon Cloud https://github.com/autogluon/autogluon-cloud/actions/runs/9456879067/job/26091603325

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, so how is it resolved just by updating to torch 2.2 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sagemaker torch 2.2 base image would align with AG's torch version 2.2 and installs torchaudio 2.2.x, so that torchaudio would also be compatible with other torch modules.

@suzhoum suzhoum merged commit b677149 into autogluon:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants