Skip to content

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented May 28, 2024

Issue #, if available:

Resolves #4186

Description of changes:

  • Fix HPO crash NN_TORCH, FASTAI
  • Ray 2.7+ requires absolute path for storage_path, so I've updated the code to do so.
  • Also fixed incorrect save location for model-internals.pkl in FastAI model, which previously was saved outside of the intended directory of the model artifact ("FastAImodel-internals.pkl" -> "FastAI/model-internals.pkl").
  • Added extra logging for incompatible version loading, to make it even more explicit that users should not do this.
  • Added note in v1.1.1 release notes on backwards incompatibility: The FastAI change is backwards incompatible, if users try to load an old artifact, it will fail to find model-internals.pkl.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
fastcore==1.5.40 fastcore==1.5.41
pydantic_core==2.18.2 pydantic_core==2.18.3
pydantic==2.7.1 pydantic==2.7.2
fastcore==1.5.40 fastcore==1.5.41
pydantic_core==2.18.2 pydantic_core==2.18.3
pydantic==2.7.1 pydantic==2.7.2

@Innixma Innixma requested review from rey-allan and suzhoum May 28, 2024 19:04
Copy link
Contributor

@rey-allan rey-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Innixma Innixma merged commit 0fcfb0e into autogluon:master May 28, 2024
@Innixma Innixma deleted the fix_hpo_nn branch April 16, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: tabular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeuralNetTorch Hyperparameter Tuning Fails with URI Scheme Error in PyArrow
3 participants