Skip to content

[tabular] Disable sklearnex for LR models due to performance degradation #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2024
Merged

[tabular] Disable sklearnex for LR models due to performance degradation #4223

merged 1 commit into from
May 24, 2024

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented May 23, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  • Disable sklearnex for LR models due to performance degradation
  • Unsure what version of sklearnex started causing this, but it is better to disable by default until we find a fix.

Version: scikit-learn-intelex-2024.4.0
Dataset: AdultIncome

                   model  score_test  score_val eval_metric
0            LinearModel    0.902293   0.904318     roc_auc
1  LinearModel_SKLEARNEX    0.863535   0.873544     roc_auc

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added bug Something isn't working module: tabular labels May 23, 2024
@Innixma Innixma added this to the 1.1.1 Release milestone May 23, 2024
@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

prateekdesai04
prateekdesai04 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@prateekdesai04 prateekdesai04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Innixma Innixma merged commit d0779c9 into autogluon:master May 24, 2024
@github-actions GitHub Actions
Copy link

Job PR-4223-e6bf80b is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4223/e6bf80b/index.html

@Innixma Innixma mentioned this pull request Jun 18, 2024
Open
@Innixma Innixma deleted the disable_sklearnex_lr branch April 16, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekdesai04 prateekdesai04 prateekdesai04 approved these changes

@rey-allan rey-allan Awaiting requested review from rey-allan

Assignees
No one assigned
Labels
bug Something isn't working module: tabular
Projects
None yet
Milestone
1.1.1 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Innixma @yinweisu @prateekdesai04