Skip to content

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented May 23, 2024

Issue #, if available:

Description of changes:

  • When can_refit_full tag was added, I forgot to add the tag to linear models. This meant we were skipping refit and using the first fold model, which gives slightly worse results that doing a proper refit.
  • This PR enables LinearModels to do the refit.
  • Because we don't yet use LinearModels in default portfolios, this doesn't impact the normal user experience.

Example on AdultIncome dataset:

Mainline:

                      model  score_test  score_val eval_metric
0          LinearModel_FULL   -0.352494  -0.326698    log_loss
1               LinearModel   -0.352494  -0.326698    log_loss

This PR:

                      model  score_test  score_val eval_metric
0          LinearModel_FULL   -0.351792        NaN    log_loss
1               LinearModel   -0.352380  -0.326852    log_loss

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added enhancement New feature or request module: tabular labels May 23, 2024
@Innixma Innixma added this to the 1.1.1 Release milestone May 23, 2024
@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
botocore==1.34.111 botocore==1.34.112
boto3==1.34.111 boto3==1.34.112
tifffile==2024.5.10 tifffile==2024.5.22
botocore==1.34.111 botocore==1.34.112
boto3==1.34.111 boto3==1.34.112
tifffile==2024.5.10 tifffile==2024.5.22

Copy link
Contributor

@rey-allan rey-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Innixma Innixma merged commit 479cf77 into autogluon:master May 24, 2024
Copy link

Job PR-4222-a25b81f is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4222/a25b81f/index.html

@Innixma Innixma deleted the fix_lr_refit branch April 16, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module: tabular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants