[tabular] add infer throughput logging #4200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Job PR-4200-9d2669d is done. |
| """ | ||
| y_pred_proba = self.predict_proba(X, **kwargs) | ||
| y_pred = get_pred_from_proba(y_pred_proba=y_pred_proba, problem_type=self.problem_type) | ||
| return y_pred | ||
|
|
||
| def predict_proba(self, X, normalize=None, **kwargs) -> np.ndarray: | ||
| def predict_proba(self, X, *, normalize: bool | None = None, record_time: bool = False, **kwargs) -> np.ndarray: |
There was a problem hiding this comment.
why do we not set the record_time as true and by default record the time taken for prediction?
There was a problem hiding this comment.
Because calling time.time takes time, and predict is something we want to take as little time as possible for the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #4162
Description of changes:
Mainline:
This PR:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.