-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[tabular] Dynamic Stacking Logging Enhancement #4208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tabular] Dynamic Stacking Logging Enhancement #4208
Conversation
|
e5320e5
to
cbc2a81
Compare
|
include_gpu_count = False | ||
if verbosity >= 3: | ||
include_gpu_count = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this can be done in a more Pythonic way
include_gpu_count = True if verbosity >= 3 else False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Updated to
include_gpu_count = (verbosity >= 3)
num_stack_levels = 0 if stacked_overfitting else org_num_stack_levels | ||
self._stacked_overfitting_occurred = stacked_overfitting | ||
|
||
# logger.info(f"\tSpent {time_spend_sub_fits}s for the sub-fit(s) during dynamic stacking.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this statement isn't needed, it's better to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! This one snuck through, removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Job PR-4208-c21c80c is done. |
Issue #, if available:
Resolves #4148
Description of changes:
force_ray_logging=True
.fit
so it is logged prior to Dynamic Stacking.This PR:
Mainline:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.