[Timeseries] Fix platform tests failing on Ubuntu and MacOS for Python 3.8 #4049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekdesai04
commented
Apr 6, 2024
| @@ -138,6 +138,7 @@ def test_all_models_can_handle_all_covariates( | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("freq", DEFAULT_SEASONALITIES.keys()) | |||
| @pytest.mark.skipif(parse_version(pd.__version__) < parse_version("2.1"), reason="Skipping test for pandas < 2.1") | |||
There was a problem hiding this comment.
Would need @shchur to advise on this specific change
There was a problem hiding this comment.
@prateekdesai04 thank you for identifying the root cause of the problems! I narrowed down the conditions under which the tests are skipped in #4051 (needed to create a new PR because I'm still not sure how to run platform tests from forks 😅).
There was a problem hiding this comment.
Should I close this PR ?
Let me know if you need help with running platform tests
suzhoum
approved these changes
Apr 6, 2024
|
|
Job PR-4049-d8e56f7 is done. |
|
Fixed by #4051, closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes failure of timeseries platform tests on Ubuntu and MacOS for Python 3.8
This PR is similar to #4040.
Link to platform tests (passing for Python 3.8): https://github.com/prateekdesai04/autogluon/actions/runs/8576700048
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.