Skip to content

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Apr 5, 2024

Issue #, if available:

Resolves #3989

Description of changes:

Upgrade Pandas from <2.2 to <2.3

TODO:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 1.1 Release milestone Apr 5, 2024
@Innixma Innixma requested review from shchur and zhiqiangdon April 5, 2024 18:36
@Innixma Innixma added dependency Related to dependency packages priority: 0 Maximum priority labels Apr 5, 2024
@Innixma Innixma mentioned this pull request Apr 5, 2024
23 tasks
@yinweisu
Copy link
Contributor

yinweisu commented Apr 5, 2024

Previous CI Run Current CI Run
vowpalwabbit==9.8.0 vowpalwabbit==9.9.0
skl2onnx==1.15.0 skl2onnx==1.16.0
vowpalwabbit==9.8.0 vowpalwabbit==9.9.0
skl2onnx==1.15.0 skl2onnx==1.16.0

@tonyhoo
Copy link
Collaborator

tonyhoo commented Apr 5, 2024

Previous CI Run Current CI Run
vowpalwabbit==9.8.0 vowpalwabbit==9.9.0
skl2onnx==1.15.0 skl2onnx==1.16.0
vowpalwabbit==9.8.0 vowpalwabbit==9.9.0
skl2onnx==1.15.0 skl2onnx==1.16.0

@prateekdesai04 any clue why pandas not showing up here?

@@ -18,7 +18,7 @@
DEPENDENT_PACKAGES = {
"boto3": ">=1.10,<2", # <2 because unlikely to introduce breaking changes in minor releases. >=1.10 because 1.10 is 3 years old, no need to support older
"numpy": ">=1.21,<1.29", # "<{N+3}" upper cap, where N is the latest released minor version, assuming no warnings using N
"pandas": ">=2.0.0,<2.2.0", # "<{N+1}" upper cap
"pandas": ">=2.2.0,<2.3.0", # "<{N+1}" upper cap # FIXME FIXME FIXME: Temp, revert lower bound to >=2.0 prior to merge
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas>=2.1.0 dropped support for Python 3.8 (changelog), so this update would require us to drop Python 3.8 support as well.

@Innixma Innixma force-pushed the upgrade_pandas_2.2 branch from 926d5c8 to 895bac4 Compare April 8, 2024 19:09
@yinweisu
Copy link
Contributor

yinweisu commented Apr 8, 2024

Previous CI Run Current CI Run

@Innixma
Copy link
Contributor Author

Innixma commented Apr 11, 2024

Replaced by #4079

@Innixma Innixma closed this Apr 11, 2024
@Innixma Innixma deleted the upgrade_pandas_2.2 branch April 16, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Related to dependency packages priority: 0 Maximum priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Pandas 2.2
4 participants