Optimization: Memoize RequiredMemberAttribute search
#1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see this will not work because of "Unloading feature" |
|
We have all of the reflection-related caches centralized to allow for unloading assembly load contexts. I'm guessing that's why some of those tests are failing. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1415 +/- ##
===========================================
+ Coverage 78.48% 78.52% +0.03%
===========================================
Files 200 200
Lines 5703 5713 +10
Branches 1168 1168
===========================================
+ Hits 4476 4486 +10
Misses 714 714
Partials 513 513 ☔ View full report in Codecov by Sentry. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see in Profiler that
.GetCustomAttribute()is a hotspot.Memoizing it will improve performance.