Add "Namespace" support #83
Conversation
|
I just noticed that @harikt has harikt/hkt-expressive-auraviewrenderer, but I'm not sure I understand totally how the namespace thing is implemented. It looks to me like it's just disregarded? |
|
Hi @jakejohns , I am a bit sick, and have some trouble with eye. So this is quick reply. I may want to look more into what you need here. Basically it was trying to work in the way expressive was doing. https://github.com/harikt/hkt-expressive-auraviewrenderer/blob/master/src/AuraViewRenderer.php#L90
So |
|
Hey @jakejohns , Thanks for making the implementation. I think you have made the namespace in the core. My repo just create namespace on top of expressive renderer. Do you have any other questions ? |
|
I have merged #80 . If you merge those changes the unit tests will pass on 7.x I believe. |
65a1d84 to
31bb404
Compare
|
Thank you. This looks good to me. @pmjones do you have any thoughts ? Else I can merge this and make a release. |
|
Hey @jakejohns , can you add some documentation to this. I will merge once you are done, do ping me so I don't miss it. |
|
@harikt how's this? |
There was a problem hiding this comment.
This looks good.
Question : Do you think we can add a way to set the namespace separator ?
So it may help to change the delimiter from :: to something else also if needed. That may be a rare case though.
UPDATE : May be that will over kill the template registry. Lets not worry about that now 👍 .
|
Thank you @jakejohns . |
Zend Expressive Template Interface defines support for namespaces using the
::scope resolution operator.@notation.Personally, I've just been using paths to basically simulate some approximation of this functionality, and had previously been considering trying to add some kind of PSR-4-like directory definition that would basically just pretend a directory structure was deeper than it was, but this seems like a solution, and seems to exist elsewhere too.
Thoughts?
(On an unrelated note, and thoughts/idea on starting 3.x anytime so we can modernize some syntax and get rid of some of the old cruft?)