Add a way to set map and path in factory #73
Conversation
|
Hey @harikt -- can you add some README documentation on this? Then I can merge it and make a minor release. |
|
Or you can merge it and make the release. :-) |
|
Sure, I will update the README.md . I don't like me sending a PR and merging the same for a few reasons. If the same person is reviewing the possibility of missing things are greater. So I prefer anyone other than me looking into it and verifying the same. So it is always for your consideration 👍 . If you put a +1 I will do the next steps ;) . |
|
@pmjones have added some information to README. Let me know if that helps. Thank you |
| <?php | ||
| $view_factory = new \Aura\View\ViewFactory; | ||
| $view = $view_factory->newInstance( | ||
| $helpers = null, |
There was a problem hiding this comment.
Shouldn't this just be null, rather than an assignment?
There was a problem hiding this comment.
You are right, it can be just null. But I wanted to show it is helpers and people can pass helpers other than null.
|
@pmjones in case you have some time. Have a look into the updated docs. I will make another release for Aura.View once you have reviewed the same. Thank you. |
|
@pmjones ping. |
|
Done :-) |
This allows to pass the map array and paths to the template registry on constructor using the ViewFactory class.