Changes for PHP 8.4 #229
Merged
Changes for PHP 8.4 #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can go to 6.x , else we need to make sure the connect method is not removed or another alternate approach needed . |
Closed
src/ExtendedPdo.php
Outdated
| @@ -100,7 +113,11 @@ public function connect(): void | |||
| // connect | |||
| $this->profiler->start(__FUNCTION__); | |||
| list($dsn, $username, $password, $options, $queries) = $this->args; | |||
| $this->pdo = new PDO($dsn, $username, $password, $options); | |||
| if(version_compare(phpversion(), '8.4.0', '<')) { | |||
There was a problem hiding this comment.
I'd remove this check and only support PHP 8.4
src/ExtendedPdo.php
Outdated
| ?ProfilerInterface $profiler = null | ||
| ): static { | ||
| $pdo = new static($dsn, $username, $password, $options ?? [], $queries, $profiler); | ||
| $pdo->establishConnection(); |
There was a problem hiding this comment.
Do we really want to connect immediately when using driver specific constructor? I'd say we always connect lazily.
|
Thanks for the effort @srjlewis. I might have advocated my points strongly but I really appreciate the work. |
|
I am ok with the changes. Thank you guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.