Skip to content

Enable PHP 7.2-8.1 compat #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 24, 2021
Merged

Enable PHP 7.2-8.1 compat #202

merged 6 commits into from
Nov 24, 2021

Conversation

iansltx
Copy link
Contributor

@iansltx iansltx commented Nov 13, 2021

No description provided.

@koriym koriym self-requested a review November 13, 2021 02:59
kenjis
kenjis reviewed Nov 13, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 13, 2021
View reviewed changes
@iansltx
Copy link
Contributor Author

iansltx commented Nov 23, 2021

Bumping this as I believe all feedback has been responded to.

@kenjis
Copy link
Member

kenjis commented Nov 24, 2021

On PHP 7.3 and 7.4

There was 1 error:

1) Aura\Sql\ConnectionLocatorTest::testNullDefault
Declaration of Aura\Sql\AbstractExtendedPdo::prepare($query, array $options = Array): PDOStatement should be compatible with PDO::prepare($statement, $options = NULL)

/home/runner/work/Aura.Sql/Aura.Sql/src/AbstractExtendedPdo.php:26
/home/runner/work/Aura.Sql/Aura.Sql/src/ExtendedPdo.php:22
/home/runner/work/Aura.Sql/Aura.Sql/tests/ConnectionLocatorTest.php:24

@kenjis kenjis merged commit 995db7a into auraphp:4.x Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@koriym koriym koriym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iansltx @kenjis @koriym