Remove vocal reduction effect #6147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #5864
Resolves: #2725
The vocal reduction effect as-is doesn't really do what it says on the tin. Rather, it takes advantage of typical mixing and mastering techniques with some success - but utterly fails when the recording doesn't match its expectations. The new ML-powered stem separation introduced with openVINO and others does not need to rely on mixing techniques and is capable of separating vocals and music, or indeed vocals and an assortment of instruments with much more success.
Once an installer for openVINO is ready, the effect therefore should be removed from Audacity and offered as a nyquist plugin instead.
cc @RyanMetcalfeInt8