Changes for Atlas.Statement to work with PHP 8.4 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmjones could we get this out? I'm running into PHP 8.4 deprecation errors. |
compwright
approved these changes
Aug 26, 2025
|
Closing this because of scope creep. New PR will follow just for 8.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed minimum version to PHP 8.1 << Please advise if this is acceptable(removed based on Pdo PR)Added version to composer.json(removed based on Pdo PR)Upgraded phpunit.xml.dist for the new phpunit version(removed based on Pdo PR)Added docblocks for all methods(out of scope)StatementTesttoStatementTestCaseto stop phpunit from trying to run tests on it since it is an abstract class (warning on console).Please advise what needs to be changed.
Thanks