Get rpm from bionic #22433
Get rpm from bionic #22433
Conversation
8be3e6a to
7f22c98
Compare
11365bf to
c232b19
Compare
| sudo apt-get update | ||
| sudo apt-get install -y wget software-properties-common | ||
| sudo apt-get install -y build-essential ca-certificates xvfb fakeroot git libsecret-1-dev rpm libx11-dev libxkbfile-dev xz-utils xorriso zsync libxss1 libgtk-3-0 libasound2 libicu-dev | ||
| sudo apt-get install -y build-essential ca-certificates xvfb fakeroot git libsecret-1-dev libx11-dev libxkbfile-dev xz-utils xorriso zsync libxss1 libgtk-3-0 libasound2 libicu-dev software-properties-common |
There was a problem hiding this comment.
I notice that software-properties-common is on the higher apt-get install line already, frpm before the present PR.
(Not strictly related to this PR, but these two apt-get install lines could be combined for slightly faster execution, I think. And --no-upgrade would skip upgrading already-installed packages. Lastly, I wonder if the package cache is already populated, and if the first apt-get update can be skipped? That one takes a while to run. I can do these in a follow-up PR if you aren't interested in going admittedly a bit off-topic with these suggestions.)
There was a problem hiding this comment.
I will add the improvement of not having two separate apt-get statements, thanks
There was a problem hiding this comment.
Let's keep the first apt-get update in place though, to keep it fail-safe.
I don't think we should use --no-upgrade, because you actually might want to pull in a newer version of a package, like a security update, if it is available.
…ure for security" This reverts commit 78cba2a.
|
Thanks @sadick254 |
Instead of upgrading completely to bionic as in #22416
because of possible glibc issues with older releases, limit the upgrade to bionic for just
rpmsoftware-properties-commonis added as earlier dependency in the script, because it contains theapt-add-repositorycommand, so we need to be sure it is in place before adding the bionic repository.