This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Fix app icons on Windows #22123
Merged
Fix app icons on Windows #22123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Since icons are binary files, I thought it to be best to address these two bugs in a single PR:
Resolves: #22122
Resolves: #22124
Description of the Change
The 256x256 icon has been re-created from the according to PNG image included in this repository. Missing icon sizes have been added to beta, dev and nightly icons.
Screenshot
Possible Drawbacks
None
Verification Process
Open the icons in an icon editor to view the changes or scale the icon size in Explorer to force it using the acccording sizes
Release Notes
Fix app icons for Windows