This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Bump minidump @aminya/minidump@0.19.0-10 #21916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aminya could you take a look at the failing CI. Linux and MacOS builds are failing. |
|
@sadick254 Yes, I am aware of the issue. It is a permission loss issue. The executables lose their permissions. This is being tracked here: |
|
Hey @aminya I am going to revert #21792 since it changed the build requirements (full xcode installation). I will wait for electron/node-minidump#43 to be resolved before having |
|
@aminya Any plans to follow up on electron/node-minidump#43? If not can we safely close this PR. |
|
Pinged @nornagon. Let's see... |
|
I asked them to release a new version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This updates minidump to 0.19.0-9. This release includes the prebuild binaries for minidump.
The upstream PR:
electron/node-minidump#42
Benefits
Verification
The CI passes.
Here is the GitHub action that generated the binraies:
https://github.com/aminya/node-minidump/actions/runs/528992133