As a side note, this is the first time this build is being run on GitHub's internal CI server, which has given us issues with this type of upgrade in the past — so I will probably spend a significant amount of energy (and possibly time) getting that working.

[apm clean] didn't seem to be working in the first place

In my experience it's worked, as it properly removed release-notes when that got cut from Atom. npm prune looks like it'll have problems with everything listed in packageDependencies (so, all of Atom's packages) as those are already marked as extraneous when running npm ls. If that can be fixed though...:+1: for using prune instead.

I get a build error when trying to build this branch on Windows 10. I can build master without error.
cmd log.txt
npm-debug.txt

@Ben3eeE Did you run script/clean prior to script/build?

Been running this for a few hours on OS X 10.11, and haven't noticed any regressions yet.

Ok, I get the same errors as @Ben3eeE while attempting to build on a brand-new laptop (so no Atom previously installed).

Perhaps this line should be set maybe_node_gyp_path=%~dp0\..\node_modules\.bin\node-gyp.cmd instead?

(Also it would be great if the set and if lines weren't outputted to the console. Not sure why they are even with @echo off.)

edit: apm.cmd needs to be changed as well. Blindly changing it to node-gyp.cmd doesn't seem to work though and it gets interpreted as a JavaScript file...

Yes I did script/clean before. Full list of commands I ran are in cmd log i uploaded. Included all from switching branch to error.

Solved it:

1. Change apm.cmd to

@echo off
setlocal

if exist "%~dp0\node.exe" (
  "%~dp0\node.exe" "%~dp0/../lib/cli.js" %*
) else (
  node.exe "%~dp0/../lib/cli.js" %*
)

1. cd into apm\node_modules\atom-package-manager\node_modules\npm\node-gyp-bin and change the path node-gyp.cmd looks for to %~dp0\..\..\..\node-gyp\bin\node-gyp.js.

Obviously this is a hacky solution, but setting npm_config_node_gyp doesn't work as described above. I'll continue investigating until I find something that works properly.

So after fixing the node-gyp issues and finishing the build process I ended up facing #10819 😦.

I also tried building on an Ubuntu 16.04 64-bit VM but got the same error as in https://travis-ci.org/atom/atom/jobs/135187713 which seems to be related to x64 compatibility.

So after fixing the node-gyp issues and finishing the build process I ended up facing #10819

I'm hitting the same issue in the ARM builds issue (#7822). I finally tracked the problem down to nodegit/nodegit#1026. In short, nodegit@0.13.0 is broken and 0.13.1 has the fix. The submodule checker is broken in 0.13.0.

NodeGit needs to publish their newest release: nodegit/nodegit#1044 (comment)

Ok, managed to fix the node-gyp issue with atom/apm#571. Now it's failing when trying to install Nodegit 0.13.1. Apparently it can't find node-pre-gyp.cmd, but I checked and the file exists...:confused:.

Retrying seems to have fixed it, but I'm not sure if it just skipped pre-gyp because it assumed that Nodegit installed properly, if it was a one-time thing, or if something else went wrong. I'll try again tomorrow.

Unfortunately now I'm stuck at a Error: Cannot find module '../build/Release/pathwatcher.node' error when starting Atom. Not sure if that's related to Nodegit.

edit: Now I'm getting 403 errors trying to download Nodegit...
double-edit: Looks like v0.13.1 for Windows isn't available on AWS yet. Will try again tomorrow.

The build servers are showing this error;

gyp: name 'openssl_fips' is not defined while evaluating condition 'openssl_fips != ""' in binding.gyp while trying to load binding.gyp

This fixed build error #10742 for me, though I have not finished building it yet. I ran out of RAM. :(
EDIT: It failed again, with a similar error.
See #10742.

Aside from Travis timing out (which we're going to solve by switching to CircleCI, #12207), I think this is ready to 🚢. atom-win is failing, but based on @damieng's work, we should be able to use AppVeyor as a drop-in replacement: in the meantime, we're actively working to fix atom-win too on Janky.

@nathansobo @BinaryMuse: what do you think? 👀 💭

Unfortunately, we've found a problem where apm is unable to require files out of Atom's ASAR bundle. This wasn't an issue for building Atom since apm uses an unpacked resource path in that case, but it is an issue for installing packages with a built version of Atom. Going to roll this back, fix the issue, and try again. 😢

@nathansobo You may want to take a look at this PR: electron/asar-require#2 May be related.

❤️ Thanks for the heads up @elprans.