Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Feb 28, 2014

This PR adds the dump-symbols task which would generate debug symbols for all the native modules, and the symbols would be uploaded to GitHub Release when publishing build.

/cc @kevinsawicki I don't know how the official build is deployed, can you help make sure the atom-mac-symbols.zip is uploaded when publishing a release in atom/atom?

@zcbenz
Copy link
Contributor Author

zcbenz commented Mar 1, 2014

@cameronmcefee I saw that there is a atom.io web hook of release events, will it affect atom.io if there is a atom-mac-symbols.zip in addition to atom-mac.zip in the release assets?

@probablycorey
Copy link

Cheng I think kevinsawicki noticed this and put in a check to make sure it
downloads the correct file. I'm on my phone so I can't check now, but I'll
look when I get home.

@cameronmcefee
Copy link

I'm not sure what this is about. I think @thedaniel is the one that will know best.

@thedaniel
Copy link
Contributor

Kevin did catch this and made the regex more restrictive. Users are given a file that matches /^atom-mac\.zip$/ or for windows /\.exe|win/i

You can attach anything else you want to a release as long as it doesn't match that.

@probablycorey
Copy link

Looks like you are good to go @zcbenz. I've also added you to the github/atom.io repo so you can see what is going on there.

@zcbenz
Copy link
Contributor Author

zcbenz commented Mar 1, 2014

@probablycorey thanks!

zcbenz added a commit that referenced this pull request Mar 1, 2014
Provide breakpad symbols of native modules
@zcbenz zcbenz merged commit 7fe3caf into master Mar 1, 2014
@zcbenz zcbenz deleted the cz-build-symbols branch March 1, 2014 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants