-
Notifications
You must be signed in to change notification settings - Fork 17.3k
1.19, Linux: Middle-clicking an unsaved tab causes entire desktop to be unresponsive to clicks #15197
Description
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
I'm on Ubuntu 16.04. Atom 1.18.0 was fine, but since updating to Atom 1.19.0, if I have a file with unsaved changes and I try to close the tab by middle-clicking on the tab, then a modal pops up (Are you sure you want to close the file without saving?), but I can't click on anything. The cursor doesn't change no matter what I hover over and no clicks register on the modal's buttons or even other (non-Atom) windows. Clicking another window doesn't focus it, bring it to the front, or get any reaction.
My computer is still responsive to keyboard inputs, though even if I alt-tab to another window, nothing reacts to my mouse still. I have to press escape on Atom's closing-confirmation modal or otherwise close it before anything reacts to my mouse again.
If I close the file tab in any other way (clicking the X button, or pressing ctrl-w), the modal and my mouse work perfectly normal. With little non-web UI experience, I'd guess the issue has to do with some kind of blocking call (like the modal) happening or a lock being hogged improperly during the middle-click event handler.
Steps to Reproduce
- Be on Ubuntu 16.04 (?)
- Open Atom, open a file in Atom, and make some changes to the file without saving.
- Middle-click on the file's tab.
Expected behavior: [What you expect to happen]
My mouse to work as usual: for the modal to be clickable, and to have the ability to click on other windows freely even while the modal is still open.
Actual behavior: [What actually happens]
See description.
Reproduces how often: [What percentage of the time does it reproduce?]
100%, tested with safe mode and a new ~/.atom directory too.
Versions
$ atom --version
Atom : 1.19.0
Electron: 1.6.9
Chrome : 56.0.2924.87
Node : 7.4.0
$ apm --version
apm 1.18.2
npm 3.10.10
node 6.9.5 x64
python 2.7.12
git 2.7.4
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.3 LTS"
$ uname -a
Linux canyon 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 19:38:41 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux