Fix linting issues exposed by linter upgrades #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues reported after upgrading golangci-lint to v1.43.0. gosec was updated in that version from v2.8.1 to v2.9.1. refs #97 refs golangci/golangci-lint#2299
I am already checking for the regex compile error and immediately returning the error if it occurs. I expect that the error wrapping I am providing will be more readable to users than an intentional panic induced stack trace would be. refs GH-96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ignore false-positive gosec G307 linting errors
Ignore gocritic
regexp.Compile()linting errorI am already checking for the regex compile error and immediately returning the error if it occurs. I expect that the error wrapping I am providing will be more readable to users than an intentional panic induced
stack trace would be.
References
regexpMust: for const patterns like v3PeerRegex, use regexp.MustCompile (gocritic)linting error #96G307: Deferring unsafe method "Close" on type "*os.File" (gosec)linting error #97