Skip to content

False positive G307: Deferring unsafe method "Close" on type "*os.File" (gosec) linting error #161

@atc0005

Description

@atc0005

This linting error was surfaced from an upgraded golangci-lint:

paths/paths.go:207:2: G307: Deferring unsafe method "Close" on type "*os.File" (gosec)
	defer func() {
		if err := destinationFileHandle.Close(); err != nil {
			log.Printf(
				"error occurred closing file %q: %v",
				destinationFile,
				err,
			)
		}
	}()
paths/paths.go:236:2: G307: Deferring unsafe method "Close" on type "*os.File" (gosec)
	defer func() {
		if err := sourceFileHandle.Close(); err != nil {
			log.Printf(
				"error occurred closing file %q: %v",
				sourceFilename,
				err,
			)
		}
	}()
checksums/checksums.go:70:2: G307: Deferring unsafe method "Close" on type "*os.File" (gosec)
	defer func() {
		if err := f.Close(); err != nil {
			log.Printf(
				"error occurred closing file %q: %v",
				file,
				err,
			)
		}
	}()
matches/matches.go:799:2: G307: Deferring unsafe method "Close" on type "*os.File" (gosec)
        defer func() {
                if err := file.Close(); err != nil {
                        log.Printf(
                                "error occurred closing file %q: %v",
                                filename,
                                err,
                        )
                }
        }()
cmd/bridge/prune.go:35:2: G307: Deferring unsafe method "Close" on type "*os.File" (gosec)
        defer func() {
                if err := file.Close(); err != nil {
                        log.Printf(
                                "error occurred closing file %q: %v",
                                appConfig.InputCSVFile,
                                err,
                        )
                }
        }()
make: *** [Makefile:110: linting] Error 1

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinglinting

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions