Skip to content

Conversation

ostromart
Copy link
Owner

The bulk of this PR is generating v2.DiscoveryResponse for LDS. This comprises:

  1. Rewriting parts of v1/config.go as v2/config.go, using protos instead of JSON structs
  2. Same for {fault, gateway, header}.go
  3. Exporting a bunch of symbols from v1 that are used in generating Listeners. This covers operations dealing with Routes and Clusters which are too extensive to port to v2 at this time.
  4. Adding some conversion utilities (util.go)

Unit testing is done by creating a new v2.DiscoveryServer with an embedded v1.DiscoveryServer. The reason for this is to avoid the circular dependency of including v2 functions in v1. v2 necessarily uses some v1 symbols (point 3 above) so v2 handling cannot be added directly to v1 at this time.

ostromart added a commit that referenced this pull request Apr 6, 2018
ostromart added a commit that referenced this pull request Apr 6, 2018
* Mixer filter fixes

* Address review comments

* Changes to listener build, revert OnListener APIs

* Move buildListener just before callbacks

* Address review comments

* Address review comments #2

* Address comments #3

* Address review comments #4

* Change return to struct value
@ostromart ostromart closed this Apr 6, 2018
@ostromart ostromart deleted the envoy_v1_to_v2 branch April 6, 2018 21:34
ostromart pushed a commit that referenced this pull request Jun 23, 2018
* # This is a combination of 5 commits.
# This is the 1st commit message:

update istio.io/api for new mcp definitions

# This is the commit message #1:

update mcp server

# This is the commit message #2:

update snapshot package

# This is the commit message #3:

use mcp service in galley/pkg/server

# This is the commit message #4:

fix linter

* update istio.io/api for new mcp definitions

update the latest mcp service definitions from istio.io/api

* fix linter error (again?)
ostromart pushed a commit that referenced this pull request Aug 1, 2018
*  Separate generated metadata into their own, top-level package: pkg/metadata

- Introduce builder pattern to the core schema types that are used by pkg/metadata,
  to ensure runtime immutability after build.
- Move the Kubernetes related machinery to their own package, pkg/kube/source, to
  separate it from core Kubernetes related abstractions and utility code.
- Bolster tests and cleanup tests accordingly.

* Add builder support to InMemory snapshot. (#3)

* Add builder support to InMemory snapshot.

* Clone resurces as well.

* Use proto.Clone, instead of manual copying.

* Add a testing server for MCP. (#4)

* Add a testing server for MCP.

* Add overridable port field.

* Don't parse the port number.

* Minor bug & linter fix (#6)

* Fix a bug in the in-memory source implementation where the item itself
was missing when publishing already-existing items during the initial
sync phase.

* Fix lint issue.

* Updates to acommodate merge.

* Update Gokg.lock.
ostromart added a commit that referenced this pull request Jan 14, 2020
* Reflect utilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant