Skip to content

Conversation

ostromart
Copy link
Owner

The bulk of this PR is generating v2.DiscoveryResponse for LDS. This comprises:

  1. Rewriting parts of v1/config.go as v2/config.go, using protos instead of JSON structs
  2. Same for {fault, gateway, header}.go
  3. Exporting a bunch of symbols from v1 that are used in generating Listeners. This covers operations dealing with Routes and Clusters which are too extensive to port to v2 at this time.
  4. Adding some conversion utilities (util.go)

Unit testing is done by creating a new v2.DiscoveryServer with an embedded v1.DiscoveryServer. The reason for this is to avoid the circular dependency of including v2 functions in v1. v2 necessarily uses some v1 symbols (point 3 above) so v2 handling cannot be added directly to v1 at this time.

sebastienvas and others added 30 commits February 20, 2018 17:25
Automatic merge from submit-queue.

Enabling cluster provisioning on no auth test

Requires istio/test-infra#701
@douglas-reid I think your are OOO, so I am going ahead and merging this. I will revert if things go south. Since pre-submit passed, I think we are good.
* Fix the isUds logic

* Add fix for client

* Add fix for client

* Fix lijnt

* Fix lijnt

* fix lint
* Update path for START_ENVOY

Proxy paths changed.

Signed-off-by: Mandar U Jog <mjog@google.com>

* Used pinned version of istio.io/proxy
istio.Version proxy tag is modified by builds.
(TODO: find why...)
Automatic merge from submit-queue.

Make sure fortio is really the latest

And some doc update based on feedback from Andra

Similar to
istio/fortio-deployment#56
Automatic merge from submit-queue.

Remove previously deprecated mixerclient.v1 config

1. Removes previously deprecated mixerclient.v1 config. Now only v2 is available.
2. Do not supply "default" attributes on the outbound route. There is no reasonable default.
Automatic merge from submit-queue.

CI/build adjustments

- pull master 
- go 1.10 was released
- pilot tests capturing junit-style test result (thanks @nmittler for converting to std tests)
- pilot test also using the recommended release style ( istio-system ) and fixed ns so it's easy
to re-run and test after (only used in circleci, new target). The new target also works manually.
- adjusted the pilot labels to allow upgrade tests ( will install istio.yaml first ). Currently pilot
tests are not compatible with normal istio configs.
Automatic merge from submit-queue.

Remove unguarded log.Info from request path

Remove `log.Info` from request path.
It causes excessive usage of zap.log and lock contention.
Automatic merge from submit-queue.

Update Grafana to 5.0 beta.

Grafana 5.0 includes a major UI update. Configuration of datasources
and dashboards is easly done via file. Dashboards have been imported
and re-exported to be on the latest schema. README and install config
updated.

See the promo video [here](https://www.youtube.com/watch?v=Izr0IBgoTZQ).
What's new  [here](http://docs.grafana.org/guides/whats-new-in-v5/).

Screenshot below
![grafana-5 0](https://user-images.githubusercontent.com/771387/36320417-ff9287bc-12fa-11e8-9e78-ccad22336435.png)
Automatic merge from submit-queue.

Support unix:// paths for pilot xDS webhook
Automatic merge from submit-queue.

Update istio release alert email destination
* Show pkg name and url when installing istio on VM

* Fix echo
Automatic merge from submit-queue.

Bump up timeout for pilot e2e tests
Automatic merge from submit-queue.

remove a flaky / incorrect test

As reported, the test case TestQueueCancelSync is flakey, but
actually that's because the test case is based on a wrong assumption. The test case
assumes that `select` chooses the clause of `donec` after closing
it, but there's a race condition that another clause can proceed
(and can be chosen), which causes the flake.

By considering this, the test case should be rather removed.

Fixes istio#3646
Automatic merge from submit-queue.

Bump up cluster nodes for pilot e2e tests on prow

The pilot e2e tests appear to be extremely flaky and take significantly
longer with a single node.  Bumping up to 4 seems to vastly greatly
things.
Automatic merge from submit-queue.

[WIP] Mixer: Make runtime2 default

Work in progress, not ready for review/checkin
* Generate JUnit Results When Running E2E Tests

* fix lint

* fix stdout and junit report

* Move junit harvest in makefile and move dependency to docker img
Automatic merge from submit-queue.

use proxy version from Dockerfile, don't prepend GCS_PATH
Automatic merge from submit-queue.

Gateway hosts may contain wildcards

Hacking away at istio#3410
…3678)

* No more dep in makefile/build - long live dep through vendor/

Follow up on having vendor/ checked in (as submodule)

We can later make new targets to automate
https://github.com/istio/istio/wiki/Vendor-FAQ#how-do-i-add--change-a-de
pendency

* Removed a couple more targets

* Remove moar

* Code review + dep update as input hash were out of sync

* Split make depend.update into .full and regular
* Always use separate upstream clusters for mixer

* Update golden files
Automatic merge from submit-queue.

Add e2e tests to verify mixer report and check for ingress

Fix istio#3418 

This test is duplicated from globalcheckandreport with ingress as destination in request count query.
xiaolanz and others added 19 commits February 26, 2018 14:36
* Reenable tcp filter racetest

* add vendor to .gitignore

* fix vendor

* remove .gitignore
* Take2 on config unification

* Few more fixes, add ingored values

* Updates

* Added the CA service for VM, update values

* Address review comments

* Use the nightly flag (will be updated once 0.6 is out)

* Fix mixer

* Add missing ports

* Add missing ports

* Use clusterip for security

* Fix configmap

* Sync prometheus, add refresh (required for larger deployments
)

* Thanks Laurent
Automatic merge from submit-queue.

Fix typo pipline -> pipeline
Automatic merge from submit-queue.

Update go-control-plane
Automatic merge from submit-queue.

Add service for Istio CA health check probe.

With the service "istio-ca", Istio CA health check probe is able to call the Istio CA gRPC service though the service name "istio-ca".
Automatic merge from submit-queue.

Missed a change for prometheus.

Added nodeport in a style consistent with ingress. This is useful for
minikube. Right now it is not recommended to create an external address
for prom, since external auth is missing, so removed the option. We may add
it later in a consistent way for all internal services.
…points (istio#3786)

Automatic merge from submit-queue.

ExternalService bug fix for discovery type DNS

If no hosts are provided for an ExternalService of discovery type DNS, the `hosts` field should be used to populate the `hosts` field for CDS
Automatic merge from submit-queue.

fix race test for TestWatchChanges

address: istio#3780

go test --v ./mixer/pkg/runtime2/... --race -run TestWatchChanges
* Enable cluster provisioning on all e2e

* Enable mason for istio-pilot-e2e

* Fixed typo

* Set TEST_TARGETS as an array

* Fix typo
istio#3739)

* Add tests to verify TCP filter sends connection.id in Check() and Report() calls.

* Fix test.

* Update test config set up function.

* Update Gopkg.* and vendor

* add comment.

* Update vendor.
* add sds client/server example for manual testing

* fix dependencies

* remove testdata dependency

* fix format with gofmt -s

* fix lint errors

* fix lint error
Automatic merge from submit-queue.

Fix issue in cluster wide postsubmit

This is already set in prow/e2e-suite.sh
* Add additional expression tests.

* Add Istio 0.6 attribute set and update some of the expression tests.
* Fix flaky test TestQuotaCache.

* Revise comment.

* Fix logging.

* Revise per review comment.
Automatic merge from submit-queue.

should not create k8s client if config dir is provided

in response to istio-users question here: https://groups.google.com/forum/#!topic/istio-users/52SiQkkTq2A

pilot should not need to create a k8s client (and therefor provide a kubeconfig file) when the `--configDir` flag is provided.  This is currently blocking the use of pilot's filewatcher adapter.  The way we are currently checking for whether a k8s client needs to be created has a bug and needs to be corrected - this will be addressed in an additional PR
* Rename and fix one bug in nodeagent.yaml

* Update readme accordingly
@ostromart ostromart closed this Feb 28, 2018
@ostromart ostromart deleted the envoy_v1_to_v2_ostromart branch February 28, 2018 00:48
ostromart added a commit that referenced this pull request Apr 6, 2018
ostromart added a commit that referenced this pull request Apr 6, 2018
* Mixer filter fixes

* Address review comments

* Changes to listener build, revert OnListener APIs

* Move buildListener just before callbacks

* Address review comments

* Address review comments #2

* Address comments #3

* Address review comments #4

* Change return to struct value
ostromart pushed a commit that referenced this pull request Jun 23, 2018
* # This is a combination of 5 commits.
# This is the 1st commit message:

update istio.io/api for new mcp definitions

# This is the commit message #1:

update mcp server

# This is the commit message #2:

update snapshot package

# This is the commit message #3:

use mcp service in galley/pkg/server

# This is the commit message #4:

fix linter

* update istio.io/api for new mcp definitions

update the latest mcp service definitions from istio.io/api

* fix linter error (again?)
ostromart pushed a commit that referenced this pull request Aug 1, 2018
*  Separate generated metadata into their own, top-level package: pkg/metadata

- Introduce builder pattern to the core schema types that are used by pkg/metadata,
  to ensure runtime immutability after build.
- Move the Kubernetes related machinery to their own package, pkg/kube/source, to
  separate it from core Kubernetes related abstractions and utility code.
- Bolster tests and cleanup tests accordingly.

* Add builder support to InMemory snapshot. (#3)

* Add builder support to InMemory snapshot.

* Clone resurces as well.

* Use proto.Clone, instead of manual copying.

* Add a testing server for MCP. (#4)

* Add a testing server for MCP.

* Add overridable port field.

* Don't parse the port number.

* Minor bug & linter fix (#6)

* Fix a bug in the in-memory source implementation where the item itself
was missing when publishing already-existing items during the initial
sync phase.

* Fix lint issue.

* Updates to acommodate merge.

* Update Gokg.lock.
ostromart pushed a commit that referenced this pull request Jan 18, 2019
ostromart pushed a commit that referenced this pull request Aug 12, 2019
* Fixing iptabes ranges

Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>

* fix shellcheck errors

Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>

* fixing ci failures #1

Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>

* fixing ci failures #2

Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>

* fixing ci failures #3

Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>

* Addressing comments

Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
ostromart pushed a commit that referenced this pull request Jan 14, 2020
Fix domainname of galley in envoy configmap istio-control/istio-discovery
ostromart added a commit that referenced this pull request Jan 14, 2020
* Installer CRD proto definition

* Review comments

* Review comments

* Add docs and examples

* Review comments

* Review comments

* Review comments

* License text

* Change IstioInstall to IstioControlPlane

* Add components struct layer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.