ostree-finalize-staged.service: RequiresMountsFor=/etc #3514
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds /etc and /var to the RequiresMountsFor= directive in the ostree-finalize-staged.service systemd unit. This change correctly ensures that these filesystems remain mounted during shutdown while the staged deployment is being finalized, preventing a race condition where systemd might unmount them prematurely. The change is sound and addresses the issue described. I have no further recommendations.
I've seen in some cases systemd try to unmount /etc quite early and then fail because it's in use. It's confusing because I don't see this in all scenarios. But regardless, in the situations where it does occur, this fixes it. Signed-off-by: Colin Walters <walters@verbum.org>
0631f13 to
9617e5f
Compare
|
We are |
|
Actually |
|
(disabling auto-merge I just want to check few more things) |
Huh...I actually don't see that So indeed, that seems like perhaps a root problem. |
I've seen in some cases systemd try to unmount /etc quite early and then fail because it's in use.
It's confusing because I don't see this in all scenarios. But regardless, in the situations where it does occur, this fixes it.