Two rust patches #3484
Merged
Two rust patches #3484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should have happened in the other PR.
- Unused imports because we weren't actually exporting the structs from those modules - glib prelude is empty now? - mount namespace usage is conditional Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Code Review
This pull request updates the ostree-sys dependency version and refactors some of the Rust bindings. The changes to conditionally compile a struct field and to add #[allow(unused_imports)] attributes seem correct and likely fix compiler warnings. However, I've identified two potential breaking API changes in rust-bindings/src/lib.rs where modules are no longer publicly re-exported. My review comments ask for clarification on these changes, as they could impact downstream users of this crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.