deploy: Don't create deployment object before deploying #3461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just pass the bits of the new deployment we want down into the checkout function. This lets us reuse the common helper to init a deployment which now always captures the device/inode. Followup from previous commit. Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Code Review
The pull request refactors the checkout_deployment_tree function to be more modular by passing individual parameters (stateroot, csum, deployserial) instead of a full OstreeDeployment object. This change delays the creation of the OstreeDeployment object until after the checkout is complete, leveraging the _ostree_sysroot_new_deployment_object helper for proper initialization, including device and inode capture. The changes improve code clarity and maintainability by centralizing object creation logic.
|
(Incidentally were this all in Rust we'd definitely be using typestate for the various states of a deployment, but typestate in C is so painful) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just pass the bits of the new deployment we want down into the checkout function. This lets us reuse the common helper to init a deployment which now always captures the device/inode.
Followup from previous commit.