repo: Add new API to write config with reload+validation #3467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ostree config set` CLI should really disallow writing invalid values. To implement that, add a new API that also *reloads* to the new config, and rolls back on failure. Closes: ostreedev#1827 Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Code Review
This pull request introduces a new API ostree_repo_write_config_and_reload to validate configuration changes before writing them to disk, enhancing the robustness of ostree's configuration management. I've identified a potential inconsistency issue and provided a fix. Additionally, I've suggested updating the test suite to reflect the new number of tests.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ostree config setCLI should really disallow writing invalid values. To implement that, add a new API that also reloads to the new config, androlls back on failure.
Closes: #1827