status: Add --json output #3451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
The pull request introduces a new --json output option for the status command, which is a valuable addition for programmatic consumption of deployment information. This is achieved by integrating a new ul-jsonwrt utility library for JSON formatting. The changes are well-structured, with a dedicated JSON writing function and corresponding test cases. However, there are a couple of areas in the newly added JSON utility library that could lead to unexpected behavior or potential issues.
5e30a01 to
68a4443
Compare
We've had a longstanding need to emit JSON to be friendlier to shell scripting tools. I hesitated for (way too long) on which JSON libraries to use, but actually since we don't need to *parse* JSON, we only need to omit it, the problem domain is super simple. util-linux has simple code for this util-linux/util-linux@b649ff9 So this commit imports it, but it will need a little massaging to build. Signed-off-by: Colin Walters <walters@verbum.org>
This gets the code to build without the rest of util-linux. Signed-off-by: Colin Walters <walters@verbum.org>
This is way long overdue, and will be useful for a variety of things but is especially motivated by soft reboot testing. Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is way long overdue, and will be useful for a variety of things
but is especially motivated by soft reboot testing.
Signed-off-by: Colin Walters walters@verbum.org