Skip to content

prepare-root: Fix error overwrite #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

prepare-root: Fix error overwrite #3449

merged 1 commit into from
Jun 25, 2025

Conversation

cgwalters
Copy link
Member

An AI code review tool spotted incorrect usage of GError. Awesome.

@cgwalters
prepare-root: Fix error overwrite
070008d 
An AI code review tool spotted incorrect usage of GError. Awesome.

Signed-off-by: Colin Walters <walters@verbum.org>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 24, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses an error handling issue by replacing glnx_throw with glnx_prefix_error. This ensures that if validate_signature fails, the specific error details are preserved.

@cgwalters cgwalters enabled auto-merge June 24, 2025 22:09
jmarrero
jmarrero approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit fda4570 into ostreedev:main Jun 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarrero jmarrero jmarrero approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @jmarrero