prepare-root: Factor out composefs handling into otcore #3445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request refactors composefs handling from ostree-prepare-root.c into libotcore by introducing otcore_mount_composefs. Key feedback:
- Critical: Arguments
deploy_pathandmount_targetare swapped in the call tootcore_mount_composefsinsrc/switchroot/ostree-prepare-root.c. - Medium: Unused variable
cfs_digestinsrc/libotcore/otcore-prepare-root.c. - Medium: Add Gtk-doc documentation for
otcore_mount_composefsinsrc/libotcore/otcore.h.
fbd2158 to
e4bc4e8
Compare
I'm thinking about creating ostree-prepare-soft-reboot.c. Prepare for this by factoring out shared helper functions.
e4bc4e8 to
2027653
Compare
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking about creating ostree-prepare-soft-reboot.c. Prepare for this by factoring out shared helper functions.