Skip to content

Conversation

ChilloManiac
Copy link
Contributor

Looking at the implementation here we can see the $VALUE is not used.

It would also be weird to have to supply a VALUE to a delete operation

Copy link

openshift-ci bot commented Apr 4, 2025

Hi @ChilloManiac. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@champtar
Copy link
Collaborator

champtar commented Apr 4, 2025

/ok-to-test

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlebon jlebon merged commit eecf887 into ostreedev:main Apr 4, 2025
26 checks passed
@jmarrero jmarrero mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants