Release 2025.2 #3396
Merged
Release 2025.2 #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but I don't see anything obviously wrong with the symbols change... |
jmarrero
approved these changes
Mar 20, 2025
|
The failure looks odd... I see that -70 is being passed in: https://github.com/cgwalters/ostree/blob/4f46d06ba8c3f8c3a8a634453312db81685d240a/tests/kolainst/destructive/auto-prune.sh#L62 as |
- First I kept wondering what the magic of 10000 was here before looking above and noticing it matched the number of dtb files. Make a shared variable so the connection is more obvious - Next, I *believe* the intention of this test was to test the edge case of bytes vs blocks, but we ended up subtracting blocks and I think recent FCOS images happened to get small enough that we started going negative here. Fix this to convert the bytes into blocks.
Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.