Skip to content

Conversation

smcv
Copy link
Contributor

@smcv smcv commented Feb 26, 2025

Helps: #3386


This does not do anything to solve the test failure, but hopefully it makes it easier to understand.

@cgwalters
Copy link
Member

Just missing a make clang-format

…ut it

Helps: ostreedev#3386
Signed-off-by: Simon McVittie <smcv@debian.org>
@smcv
Copy link
Contributor Author

smcv commented Feb 26, 2025

I think the result is less readable, but OK.

@cgwalters
Copy link
Member

If you feel even mildly strongly it's fine by me to slap an ignore on it and manually format too.

@cgwalters
Copy link
Member

I guess either way it'd likely be more readable with a little helper static inline yesno(v: uint8) -> char { v ? 'y' : 'n' } or so? But again I have no strong opinion at this at all other than make clang-format is happy just so we have a default consistent baseline.

@cgwalters cgwalters merged commit a433e44 into ostreedev:main Mar 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants