Skip to content

tests: Attempt to update auto-prune test #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

tests: Attempt to update auto-prune test #3285

merged 1 commit into from
Aug 30, 2024

Conversation

cgwalters
Copy link
Member

We need to look in the journal since
3d07a80

@ericcurtin ericcurtin enabled auto-merge August 15, 2024 17:56
@cgwalters
Copy link
Member Author

Ugh of course our journal grep command pulls up itself because the test is actually logging to the journal...

jlebon
jlebon reviewed Aug 28, 2024
View reviewed changes
@jlebon jlebon force-pushed the drop-deploy-print branch 2 times, most recently from f54e1e3 to 85899fc Compare August 28, 2024 19:40
@cgwalters
Copy link
Member Author

Thanks for working on this, honestly what I hit is my cosa devenv bitrotted...too many build/test environments

@cgwalters cgwalters force-pushed the drop-deploy-print branch 2 times, most recently from aacb17f to eef4fb2 Compare August 30, 2024 17:39
@cgwalters cgwalters self-assigned this Aug 30, 2024
jlebon
jlebon reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to circle back on this!

@cgwalters
Copy link
Member Author

[2024-08-30T18:39:17.547Z] Aug 30 18:39:15 qemu0 kola-runext-auto-prune.sh[2375]: /usr/local/bin/kola-runext-auto-prune.sh: line 81: assert_file_has_context: command not found

Whee hooray for interpreted code 😢

@cgwalters
deploy: Log to journal for boot space, not stderr
4f46d06 
bootc doesn't run as a systemd unit, and this pollutes stderr.

Signed-off-by: Colin Walters <walters@verbum.org>
@github-actions github-actions bot added the area/prepare-root Issue relates to ostree-prepare-root label Aug 30, 2024
@ericcurtin ericcurtin merged commit 4207d92 into ostreedev:main Aug 30, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon left review comments

@ericcurtin ericcurtin ericcurtin approved these changes

Assignees

@cgwalters cgwalters

Labels
area/prepare-root Issue relates to ostree-prepare-root
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgwalters @ericcurtin @jlebon