keyfile-utils: Add API to parse tristate strings #3276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for using this in multiple places. Add unit tests.
jlebon
approved these changes
Jul 11, 2024
| gboolean | ||
| _ostree_parse_tristate (const char *s, OtTristate *out_tri, GError **error) | ||
| { | ||
| if (strcmp (s, "maybe") == 0) |
There was a problem hiding this comment.
This isn't new, but "maybe" is a very confusing value to support. Feels like "auto" would capture it better?
| return TRUE; | ||
| } | ||
| // If it's invalid, be clear a tristate was expected. | ||
| return glnx_throw (error, "Invalid tri-state value: %s", s); |
There was a problem hiding this comment.
Minor: looks like we're losing the G_KEY_FILE_ERROR_INVALID_VALUE semantics here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep for using this in multiple places. Add unit tests.