Skip to content

Conversation

osteele
Copy link
Owner

@osteele osteele commented May 21, 2025

This commit:

  • Fix errcheck errors by handling return values from fmt.Fprintf
  • Fix De Morgan's law conditional statements
  • Replace strings.SplitN with strings.Split where appropriate
  • Replace bytes.Replace with bytes.ReplaceAll
  • Replace strings.Replace with strings.ReplaceAll
  • Merge conditional assignment into variable declaration
  • Remove obsolete 'gas' linter directives

Fixes #68

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Jekyll.

osteele added 2 commits May 21, 2025 16:58
This commit:
- Fix errcheck errors by handling return values from fmt.Fprintf
- Fix De Morgan's law conditional statements
- Replace strings.SplitN with strings.Split where appropriate
- Replace bytes.Replace with bytes.ReplaceAll
- Replace strings.Replace with strings.ReplaceAll
- Merge conditional assignment into variable declaration
- Remove obsolete 'gas' linter directives

Fixes #68
- Add --issues-exit-code=1 to ensure CI fails when linter finds issues
- This enforces proper code formatting and quality checks
@osteele osteele requested a review from danog May 21, 2025 08:25
@danog danog merged commit 86ddc73 into main Jun 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linter errors reported by golangci-lint
2 participants