✨ Added github codeowners to contributors list influencing contributors check #4611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4611 +/- ##
==========================================
+ Coverage 66.80% 68.27% +1.46%
==========================================
Files 230 249 +19
Lines 16602 18874 +2272
==========================================
+ Hits 11091 12886 +1795
- Misses 4808 5129 +321
- Partials 703 859 +156 🚀 New features to boost your workflow:
|
|
Taking a look this afternoon, would merging this close #4551 ? |
|
/scdiff generate Contributors |
Yep we could also just close it now and work off of this. This is the simplified version of that with the changes you requested. |
Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com>
Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com>
Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com>
…scorecard into 3931-codeowners-new
spencerschrock
approved these changes
May 20, 2025
spencerschrock
approved these changes
May 20, 2025
I think I need to export it because I use it in 2 other files. I could duplicate it though so its not exported. https://github.com/ossf/scorecard/pull/4611/files#diff-31e1ee0c52fdbfa08b1f646de83cdae712e6a9fbe98c0deabb38fa36e533c04bR227 |
Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com>
Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com>
They're in the same package though, so should be visible still |
Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com>
Oh you're right my bad! |
|
Thanks! |
renewitt
pushed a commit
to renewitt/scorecard
that referenced
this pull request
May 29, 2025
…rs check (ossf#4611) * ✨ added github codeowners to contributors list Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ deduped code owners and contributors plus other fixes Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ index out of bounds check Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ fixed cog complexity linting error Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ updated e2e repo and rename file param Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ removed duplicate e2e test repo Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ removed export of github codeowner paths Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> --------- Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> Signed-off-by: Rachael Newitt <renewitt@google.com>
renewitt
pushed a commit
to renewitt/scorecard
that referenced
this pull request
May 29, 2025
…rs check (ossf#4611) * ✨ added github codeowners to contributors list Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ deduped code owners and contributors plus other fixes Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ index out of bounds check Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ fixed cog complexity linting error Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ updated e2e repo and rename file param Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ removed duplicate e2e test repo Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> * ✨ removed export of github codeowner paths Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> --------- Signed-off-by: Luke Harrison <Luke.Harrison1@ibm.com> Signed-off-by: Rachael Newitt <renewitt@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds code owners to the list returned by
getContributorsfor github clientAdds
isCodeOwnerflag to Clients.user for future use of owners returned bygetContributors(Feature: Probe whether repo has up-to-date CODEOWNERS #3931).The contributorsFromOrgOrCompany probe will count these code owners toward final score. Basically a codeowners orgs/companies will count towards the 3 required orgs/companies (Feature: Probe whether repo has up-to-date CODEOWNERS #3931 (comment)).
PR title follows the guidelines defined in our pull request documentation
What is the current behavior?
Currently the getContributors function only returns the contributors to the repo.
What is the new behavior (if this is a feature change)?**
Now the getContributors function also returns the users listed in the repo's CODEOWNERS file.
Which issue(s) this PR fixes
Contributes to #3931
See here for discussion #4551 (comment)
Special notes for your reviewer
I also tried to solve the issue of "verified external contributors" by allowing users to add an # @verified comment to their CODEOWNERS file along with the user names of the verified external contributors as per #3931 (comment).
Lastly to parse the CODEOWNERS file I am using this package by @hmarr. I can manually parse it with regex but this was pretty easy to use and made things a lot simpler.
Does this PR introduce a user-facing change?
NONE