✨ adds support for configs ending in .yaml #4568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, can you please fix DCO? |
There was a problem hiding this comment.
Thanks for fixing the test. Just a few small comments.
And you'll still need to fix DCO on the original commit (7857e04) before I can merge this
https://github.com/ossf/scorecard/pull/4568/checks?check_run_id=39323374807
Signed-off-by: Ratan Kumar <ratan@Ratans-MacBook-Pro.local>
Signed-off-by: Ratan Kumar <ratan@Ratans-MacBook-Pro.local>
Signed-off-by: Ratan Kumar <ratan@Ratans-MacBook-Pro.local>
This partially reverts commit 4479ae6. Signed-off-by: Spencer Schrock <sschrock@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4568 +/- ##
==========================================
+ Coverage 66.80% 68.39% +1.59%
==========================================
Files 230 249 +19
Lines 16602 18829 +2227
==========================================
+ Hits 11091 12879 +1788
- Misses 4808 5097 +289
- Partials 703 853 +150 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #4552
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
#4552
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)