✨ gitfile: fetch no tags during clone #4563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are only concerned with the files at the requested commit, and were already doing a shallow clone. This performance optimization results in a 3x speedup on my machine when analyzing the ossf/scorecard repository with --file-mode git. Signed-off-by: Spencer Schrock <sschrock@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4563 +/- ##
==========================================
+ Coverage 66.80% 68.38% +1.58%
==========================================
Files 230 249 +19
Lines 16602 18822 +2220
==========================================
+ Hits 11091 12872 +1781
- Misses 4808 5097 +289
- Partials 703 853 +150 🚀 New features to boost your workflow:
|
|
Great improvement! LGTM. |
raghavkaul
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
optimization
What is the current behavior?
We already doing a shallow clone, but
go-gitfetches all tags from the remote by default. We don't need them for this operation, we just care about the files at HEAD (or whatever commit is requested).What is the new behavior (if this is a feature change)?**
Don't fetch tags. This performance optimization results in a 3x speedup on my machine when analyzing the
ossf/scorecardrepository with--file-mode git. It practically gets performance up to--file-mode archivelevelsSee upstream discussion here
Before: 29.974s
After: 8.644s
(archive): 5.173s
NONE
Which issue(s) this PR fixes
Special notes for your reviewer
scdiff tests pass (though the workflow command we have isn't configured to do this)
With a slightly modified scdiff to use
--file-mode git, the difference is 2x or so:Before: 4m 11s
After: 2m 21s
(archive mode): 2m 15s
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)