✨ probe: releases with verified provenance #4141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4141 +/- ##
==========================================
- Coverage 66.11% 59.97% -6.14%
==========================================
Files 232 215 -17
Lines 16567 15637 -930
==========================================
- Hits 10954 9379 -1575
- Misses 4925 5564 +639
- Partials 688 694 +6 |
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
spencerschrock
approved these changes
Jun 6, 2024
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
Jun 12, 2024
* add projectpackageversions to signed releases raw results Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> * finding: add NewNot* helpers, fix error msg Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> * probe: releasesHaveVerifiedProvenance Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> * logging Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> * fix tests and lint Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> * address comments Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> * remove unused Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> * fix merge conflict Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> --------- Signed-off-by: Raghav Kaul <raghavkaul+github@google.com> Signed-off-by: balteraivshay <avishay.balter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add a probe to check for verified provenance. Look up the package associated with the GitHub/GitLab project, and check if the package. In the current version, this check only supports NPM packages.
Which issue(s) this PR fixes
Closes #3038.
Addresses #1776 and #298.
Special notes for your reviewer
For now, treating "No package found" the same as "this ecosystem doesn't have packages / doesn't support publishing provenance" - with
finding.NotAvailable. In the future, we might add ecosystem detection to make the latter scenariofinding.NotApplicable.Does this PR introduce a user-facing change?