Skip to content

BUG: Gitlab Commits Before Date Needs More Logic #3193

@jimrobison

Description

@jimrobison

Describe the bug
Using the first commit returned has proven to not be the best source for the retrieval of merge requests details.

Expected behavior
The before field is intended to help limit the number of merge request details based on the last commit date for the default branch. By using the first record, this may not always include all of the related merge requests, throwing the scoring calculation off.

Additional context
I believe it would be better to calculate the date by cycling through the commits to determine the best date to use. I have a this is a working branch that I'm working through while validating the Code-Review check's scores

Metadata

Metadata

Assignees

No one assigned

    Labels

    gitlabIssue related to Scorecard's GitLab clientgood first issueGood for newcomerskind/bugSomething isn't working

    Type

    No type

    Projects

    Status

    Backlog - Bugs

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions