Skip to content

BUG: Code-Review missing review markers #4038

@emaste

Description

@emaste

Describe the bug
Code-Review misses review indicators used by FreeBSD.

Reproduction steps
Steps to reproduce the behavior:

  1. Inspect Code-Review for freebsd-src https://securityscorecards.dev/viewer/?uri=github.com/freebsd/freebsd-src
  2. Review recent FreeBSD commits https://github.com/freebsd/freebsd-src/commits/main/
  3. Observe Reviewed by: tags and/or Phabricator URLs indicating review took place, e.g. freebsd/freebsd-src@1b74875

Expected behavior

  • Match Reviewed by: as a synonym for Reviewed-by: as evidence of review
  • Consider following Phabricator review links and extracting review state

Additional context
I suspect FreeBSD may be one of the more significant remaining open source users of Phabricator, and for us review evidence should be included in the commit message directly (via Reviewed by:). It may or may not be worth the effort to parse Phabricator state for other projects that use Phabricator and do not indicate the review state in the commit message. LLVM used to be an example of such a project, but they use a completely GitHub-based workflow now.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions